nate/study-bible-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #5 from nmemmert/claude/test-coverage-analysis-R2olv

Browse Source 
Fix Greek lookup returning "Lookup failed"
This commit is contained in:
nmemmert
2026-05-27 13:39:47 -04:00
committed by GitHub
parent f35ae80dd9 dde2fecba2
commit 25f0328c15
1 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/App.jsx
+25 -16
View File
@@ -855,26 +855,35 @@ const App = () => {
const isHebrewStrongNumber = (query) => /^H\d+$/i.test(query.trim());
const fetchBollsDefinition = async (query) => {
const encoded = encodeURIComponent(query.trim());
const dictUrl = `https://bolls.life/dictionary-definition/BDBT/${encoded}/`;
const isGreek = isGreekStrongNumber(query);
const isHebrew = isHebrewStrongNumber(query);
// Direct Strong's number lookup (G prefix = Greek/Thayer's, H prefix = Hebrew/BDB)
if (isGreekStrongNumber(query) || isHebrewStrongNumber(query)) {
const response = await fetch(dictUrl);
if (isGreek || isHebrew) {
// The bolls.life API uses bare numbers in the URL (no G/H prefix).
// We filter returned results by topic prefix to get the right language.
const bare = query.trim().replace(/^[GgHh]/, '');
const response = await fetch(`https://bolls.life/dictionary-definition/BDBT/${encodeURIComponent(bare)}/`);
if (!response.ok) return null;
const definitions = await response.json();
return Array.isArray(definitions) && definitions.length > 0 ? definitions : null;
let defs;
try { defs = await response.json(); } catch { return null; }
if (!Array.isArray(defs) || defs.length === 0) return null;
const prefix = isGreek ? 'G' : 'H';
const filtered = defs.filter((d) => String(d.topic ?? '').toUpperCase().startsWith(prefix));
return filtered.length > 0 ? filtered : defs;
}
// English word — full-text search, then filter to Greek entries only
const searchResponse = await fetch(`https://bolls.life/search-dictionaries/BDBT/${encoded}/`);
if (searchResponse.ok) {
const results = await searchResponse.json();
const greekResults = Array.isArray(results)
? results.filter((r) => String(r.topic ?? '').startsWith('G'))
: [];
if (greekResults.length > 0) return [greekResults[0]];
}
// English word — full-text search, filter to Greek entries only
const encoded = encodeURIComponent(query.trim());
try {
const searchResponse = await fetch(`https://bolls.life/search-dictionaries/BDBT/${encoded}/`);
if (searchResponse.ok) {
const results = await searchResponse.json();
const greekResults = Array.isArray(results)
? results.filter((r) => String(r.topic ?? '').startsWith('G'))
: [];
if (greekResults.length > 0) return [greekResults[0]];
}
} catch { /* fall through */ }
return null;
};