Harden sync and security; add IQ Bible, templates, password reset, backups
Build and Push Docker Image / build-and-push (push) Successful in 7m14s
Build and Push Docker Image / build-and-push (push) Successful in 7m14s
Sync and data safety - Autosave flushes on leaving a study or the tab; storage-full errors are reported - Unsynced studies, deletes and ink are queued and retried when back online - Deletes propagate across devices (with a "Keep it" undo) and no longer resurrect - Server assigns study versions (no client-clock conflicts); "Combine both" merges a conflicted study chunk by chunk - Reading-plan progress made offline is merged, not overwritten; plans, ink and marks are cleared from the device on sign-out Security - Block SSRF through the ntfy reminder URL; failure-only rate limiting per IP and account; constant-time login; TOTP replay protection; input validation; SESSION_SECRET required in production; admin user delete fixed - Forgot password: one-time code sent to the account's ntfy topic Features - IQ Bible proxy (route allow-list, text-only caching per its terms): more commentaries, lexicons, study aids, daily verse and devotional, plan calendar export, narrations, podcast background - Study templates, reading-plan catch-up, account export, daily database snapshots Tests and tooling - ESLint config; App tests split into src/test; tests for sync queues, library hook, merge, templates, IQ Bible UI and reset form Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
nmemmertandClaude Sonnet 5.5 committed
1 parent
6bb392933a
commit
f274bc9c8a
67 files changed
+4734
-1569
No files matched your search
@@ -0,0 +1,251 @@
|
||||
import { screen, fireEvent, waitFor } from '@testing-library/react';
|
||||
import userEvent from '@testing-library/user-event';
|
||||
import { vi, describe, test, expect } from 'vitest';
|
||||
import { installAppLifecycle, goToStudyWith3Chunks, mockChapterData, mockGreekDict, buildFetchMock, renderApp, loadChapter, addChunk, findChunkCounter } from './appHarness.jsx';
|
||||
|
||||
installAppLifecycle();
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Initial render
|
||||
// ---------------------------------------------------------------------------
|
||||
describe('Initial render', () => {
|
||||
test('shows the home page with "My Studies" heading', async () => {
|
||||
await renderApp();
|
||||
expect(screen.getByText('My Studies')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('shows "No projects yet" when storage is empty', async () => {
|
||||
await renderApp();
|
||||
expect(screen.getByText(/no projects yet/i)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('shows "New Project" button on home page', async () => {
|
||||
await renderApp();
|
||||
expect(screen.getAllByRole('button', { name: /new project/i }).length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
test('clicking "New Project" shows the project setup form', async () => {
|
||||
const user = userEvent.setup();
|
||||
await renderApp();
|
||||
await user.click(screen.getAllByRole('button', { name: /new project/i })[0]);
|
||||
expect(await screen.findByText('New study')).toBeInTheDocument();
|
||||
expect(screen.getByRole('button', { name: /load chapter/i })).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('setup form shows book and chapter inputs, and uses the BSB', async () => {
|
||||
const user = userEvent.setup();
|
||||
await renderApp();
|
||||
await user.click(screen.getAllByRole('button', { name: /new project/i })[0]);
|
||||
expect(screen.queryByText('Translation')).not.toBeInTheDocument();
|
||||
expect(screen.getByText('Book')).toBeInTheDocument();
|
||||
expect(screen.getByText('Chapter')).toBeInTheDocument();
|
||||
expect(screen.getByText(/Berean Standard Bible/)).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Loading a chapter
|
||||
// ---------------------------------------------------------------------------
|
||||
describe('Loading a chapter', () => {
|
||||
test('transitions to the chunk setup view on success', async () => {
|
||||
await loadChapter();
|
||||
expect(screen.getByText(/Scripture & Chunks/i)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('renders verse text after loading', async () => {
|
||||
await loadChapter();
|
||||
expect(screen.getByText(/Paul, a servant of God/i)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('shows "0 created" initially', async () => {
|
||||
await loadChapter();
|
||||
expect(screen.getByText('0 created')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('shows an error message when the API returns a non-ok response', async () => {
|
||||
vi.stubGlobal('fetch', vi.fn((url) => {
|
||||
if (url.includes('available_translations')) {
|
||||
return Promise.resolve({ ok: true, json: () => Promise.resolve(['BSB']) });
|
||||
}
|
||||
return Promise.resolve({ ok: false });
|
||||
}));
|
||||
const user = userEvent.setup();
|
||||
await renderApp();
|
||||
await user.click(screen.getAllByRole('button', { name: /new project/i })[0]);
|
||||
await user.click(screen.getByRole('button', { name: /load chapter/i }));
|
||||
await screen.findByText(/unable to load chapter/i);
|
||||
});
|
||||
|
||||
test('shows an error message when chapter data contains no verses', async () => {
|
||||
vi.stubGlobal('fetch', buildFetchMock({ chapterData: { chapter: { content: [] } } }));
|
||||
const user = userEvent.setup();
|
||||
await renderApp();
|
||||
await user.click(screen.getAllByRole('button', { name: /new project/i })[0]);
|
||||
await user.click(screen.getByRole('button', { name: /load chapter/i }));
|
||||
await screen.findByText(/invalid bible data/i);
|
||||
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Chunk management
|
||||
// ---------------------------------------------------------------------------
|
||||
describe('Chunk management', () => {
|
||||
test('creates a chunk by clicking a verse range', async () => {
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'Grace and peace');
|
||||
expect((await screen.findAllByText(/1[-–]3/)).length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
test('chunk count increments after each addition', async () => {
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'Paul, a servant');
|
||||
await screen.findByText('1 created');
|
||||
addChunk('In hope of eternal', 'Grace and peace');
|
||||
await screen.findByText('2 created');
|
||||
});
|
||||
|
||||
test('prevents adding a duplicate chunk range', async () => {
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'In hope of eternal');
|
||||
await screen.findByText('1 created');
|
||||
addChunk('Paul, a servant', 'In hope of eternal');
|
||||
await screen.findByText(/That chunk already exists/i);
|
||||
});
|
||||
|
||||
test('deletes a chunk', async () => {
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'In hope of eternal');
|
||||
await screen.findByText('1 created');
|
||||
fireEvent.click(screen.getByRole('button', { name: /delete/i }));
|
||||
await screen.findByText('0 created');
|
||||
});
|
||||
|
||||
test('"Begin Studying" is disabled when no chunks exist', async () => {
|
||||
await loadChapter();
|
||||
expect(screen.getByRole('button', { name: /begin studying/i })).toBeDisabled();
|
||||
});
|
||||
|
||||
test('"Begin Studying" is enabled once a chunk exists', async () => {
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'In hope of eternal');
|
||||
await screen.findByText('1 created');
|
||||
expect(screen.getByRole('button', { name: /begin studying/i })).not.toBeDisabled();
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
describe('Study view navigation', () => {
|
||||
test('transitions to study view when "Begin Studying" is clicked', async () => {
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'In hope of eternal');
|
||||
await screen.findByText('1 created');
|
||||
fireEvent.click(screen.getByRole('button', { name: /begin studying/i }));
|
||||
await findChunkCounter(1, 1);
|
||||
});
|
||||
|
||||
test('"Previous Chunk" is disabled on the first chunk', async () => {
|
||||
await goToStudyWith3Chunks();
|
||||
expect(screen.getByRole('button', { name: /previous chunk/i })).toBeDisabled();
|
||||
});
|
||||
|
||||
test('"Next Chunk" advances to the second chunk', async () => {
|
||||
await goToStudyWith3Chunks();
|
||||
expect(await findChunkCounter(1, 3)).toBeInTheDocument();
|
||||
fireEvent.click(screen.getByRole('button', { name: /next chunk/i }));
|
||||
expect(await findChunkCounter(2, 3)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('"Next Chunk" is disabled on the last chunk', async () => {
|
||||
await goToStudyWith3Chunks();
|
||||
fireEvent.click(screen.getByRole('button', { name: /next chunk/i }));
|
||||
fireEvent.click(screen.getByRole('button', { name: /next chunk/i }));
|
||||
expect(await findChunkCounter(3, 3)).toBeInTheDocument();
|
||||
expect(screen.getByRole('button', { name: /next chunk/i })).toBeDisabled();
|
||||
});
|
||||
|
||||
test('"Previous Chunk" returns to prior chunk after advancing', async () => {
|
||||
await goToStudyWith3Chunks();
|
||||
fireEvent.click(screen.getByRole('button', { name: /next chunk/i }));
|
||||
expect(await findChunkCounter(2, 3)).toBeInTheDocument();
|
||||
fireEvent.click(screen.getByRole('button', { name: /previous chunk/i }));
|
||||
expect(await findChunkCounter(1, 3)).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Greek word lookup
|
||||
// ---------------------------------------------------------------------------
|
||||
async function goToStudyAndAddGreekWord(fetchMock) {
|
||||
if (fetchMock) vi.stubGlobal('fetch', fetchMock);
|
||||
await loadChapter();
|
||||
addChunk('Paul, a servant', 'In hope of eternal');
|
||||
await screen.findByText('1 created');
|
||||
fireEvent.click(screen.getByRole('button', { name: /begin studying/i }));
|
||||
await findChunkCounter(1, 1);
|
||||
fireEvent.click(screen.getByRole('tab', { name: /word study/i }));
|
||||
fireEvent.click(screen.getByRole('button', { name: /add word/i }));
|
||||
await screen.findByPlaceholderText(/G4102, H7225, 4102/i);
|
||||
}
|
||||
|
||||
describe('Greek word lookup', () => {
|
||||
test('adds a Greek word entry form', async () => {
|
||||
await goToStudyAndAddGreekWord();
|
||||
expect(screen.getByPlaceholderText(/G4102, H7225, 4102/i)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('populates fields after a successful lookup', async () => {
|
||||
await goToStudyAndAddGreekWord(buildFetchMock({ greekData: mockGreekDict }));
|
||||
fireEvent.change(screen.getByPlaceholderText(/G4102, H7225, 4102/i), { target: { value: 'G4102' } });
|
||||
fireEvent.click(screen.getByRole('button', { name: /look up greek/i }));
|
||||
await screen.findByDisplayValue('πίστις');
|
||||
expect(screen.getByDisplayValue('pistis')).toBeInTheDocument();
|
||||
// With no gloss-map entry, the English gloss falls back to the KJV
|
||||
// definition, so it matches the Short Definition field.
|
||||
expect(screen.getAllByDisplayValue('faith, belief')).toHaveLength(2);
|
||||
});
|
||||
|
||||
test('shows "No definition found." when the API returns an empty array', async () => {
|
||||
await goToStudyAndAddGreekWord(buildFetchMock({ greekData: {} }));
|
||||
fireEvent.change(screen.getByPlaceholderText(/G4102, H7225, 4102/i), { target: { value: 'G4102' } });
|
||||
fireEvent.click(screen.getByRole('button', { name: /look up greek/i }));
|
||||
await screen.findByDisplayValue('No definition found.');
|
||||
});
|
||||
|
||||
test('shows "Lookup failed." on network error', async () => {
|
||||
await goToStudyAndAddGreekWord(
|
||||
vi.fn((url) => {
|
||||
if (url.includes('available_translations')) {
|
||||
return Promise.resolve({ ok: true, json: () => Promise.resolve(['BSB']) });
|
||||
}
|
||||
if (url.includes('bible.helloao.org')) {
|
||||
return Promise.resolve({ ok: true, json: () => Promise.resolve(mockChapterData) });
|
||||
}
|
||||
return Promise.reject(new Error('Network error'));
|
||||
}),
|
||||
);
|
||||
fireEvent.change(screen.getByPlaceholderText(/G4102, H7225, 4102/i), { target: { value: 'G4102' } });
|
||||
fireEvent.click(screen.getByRole('button', { name: /look up greek/i }));
|
||||
await screen.findByDisplayValue('Lookup failed.');
|
||||
});
|
||||
|
||||
test('lookup is skipped when query is empty', async () => {
|
||||
const fetchSpy = buildFetchMock();
|
||||
await goToStudyAndAddGreekWord(fetchSpy);
|
||||
const callCountBefore = fetchSpy.mock.calls.length;
|
||||
fireEvent.click(screen.getByRole('button', { name: /look up greek/i }));
|
||||
await waitFor(() => {
|
||||
expect(fetchSpy.mock.calls.length).toBe(callCountBefore);
|
||||
});
|
||||
});
|
||||
|
||||
test('removes a Greek word entry', async () => {
|
||||
await goToStudyAndAddGreekWord();
|
||||
expect(screen.getByPlaceholderText(/G4102, H7225, 4102/i)).toBeInTheDocument();
|
||||
fireEvent.click(screen.getByRole('button', { name: /^delete$/i }));
|
||||
await waitFor(() => {
|
||||
expect(screen.queryByPlaceholderText(/G4102, H7225, 4102/i)).not.toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user