nate/skywatch
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Don't write undefined values to .env file

Browse Source 
- Add proper defaults when writing settings to .env
- Prevents 'undefined' string from appearing in environment variables
- Ensures fallback values are used when settings are partially updated
This commit is contained in:
nmemmert committed 2026-01-14 15:53:21 -05:00
1 parent 0465d7ffad
commit 8942d41354
1 file changed
+11 -11
Download Patch File Download Diff File Expand all files Collapse all files
server/index.js
+11 -11
View File
@@ -676,20 +676,20 @@ app.post('/api/settings', (req, res) => {
return res.status(400).json({ error: 'Timeout must be at least 1000ms' }); return res.status(400).json({ error: 'Timeout must be at least 1000ms' });
} }
const envContent = `EMAIL_ENABLED=${email_enabled} const envContent = `EMAIL_ENABLED=${email_enabled || false}
EMAIL_HOST=${email_host} EMAIL_HOST=${email_host || 'smtp.gmail.com'}
EMAIL_PORT=${email_port} EMAIL_PORT=${email_port || 587}
EMAIL_USER=${email_user} EMAIL_USER=${email_user || ''}
EMAIL_PASS=${email_pass || process.env.EMAIL_PASS || ''} EMAIL_PASS=${email_pass || process.env.EMAIL_PASS || ''}
EMAIL_FROM=${email_from} EMAIL_FROM=${email_from || ''}
EMAIL_TO=${email_to} EMAIL_TO=${email_to || ''}
WEBHOOK_ENABLED=${webhook_enabled} WEBHOOK_ENABLED=${webhook_enabled || false}
WEBHOOK_URL=${webhook_url} WEBHOOK_URL=${webhook_url || ''}
CHECK_INTERVAL=${check_interval} CHECK_INTERVAL=${check_interval || 60000}
TIMEOUT=${timeout} TIMEOUT=${timeout || 5000}
TIMEZONE=${timezone || 'UTC'} TIMEZONE=${timezone || 'UTC'}
RETENTION_DAYS=${retention_days || 7} RETENTION_DAYS=${retention_days || 7}
AUTO_CLEANUP_ENABLED=${auto_cleanup_enabled} AUTO_CLEANUP_ENABLED=${auto_cleanup_enabled || false}
CONSECUTIVE_FAILURES=${consecutive_failures || 3} CONSECUTIVE_FAILURES=${consecutive_failures || 3}
GRACE_PERIOD=${grace_period || 300} GRACE_PERIOD=${grace_period || 300}
DOWNTIME_THRESHOLD=${downtime_threshold || 600} DOWNTIME_THRESHOLD=${downtime_threshold || 600}